Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-933246: adding missed fix for HTAP parameter removal #787

Merged
5 commits merged into from
Oct 12, 2023
Merged

SNOW-933246: adding missed fix for HTAP parameter removal #787

5 commits merged into from
Oct 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 7, 2023 •
edited by ghost
Loading

Description

sdk issue 693
Some cases for HTAP metadata/parameter removal was missed in September release. Fix them and add test case as well.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@ghost ghost self-requested a review as a code owner October 7, 2023 00:40
@ghost ghost requested a review from sfc-gh-pfus October 7, 2023 00:42
@ghost ghost requested review from sfc-gh-pfus and sfc-gh-mhofman October 12, 2023 00:05
@ghost ghost merged commit 8c2feaa into master Oct 12, 2023
18 checks passed
@ghost ghost deleted the SNOW-933246-HTAP-param-removal branch October 12, 2023 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus Awaiting requested review from sfc-gh-pfus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pfus @sfc-gh-mhofman @sfc-gh-ext-simba-hx